fix(ci): remove duplicate python-ci call from pr-validation.yml by williaby · Pull Request #80 · ByronWilliamsCPA/audio-processor

williaby · 2026-09-05T17:20:02Z

What

Removes the core-validation job from .github/workflows/pr-validation.yml.
That job re-invoked the shared python-ci.yml reusable workflow at the same
pinned SHA (7d12f5486ab5c856397ebaa4acd3c99ca385227c) already called by the
ci job in .github/workflows/ci.yml.

Before/after

Before: the reusable ran twice per pull request, once from ci.yml (line 33)
and once from pr-validation.yml (line 37), duplicating quality checks, unit
tests, integration tests, security tests, coverage combine, LLM governance,
and the Python matrix.
After: the reusable runs once per pull request, from ci.yml only.

Files changed

.github/workflows/pr-validation.yml: removed the core-validation job;
updated the validation-summary job (which produces the required
Dependency & Standards Validation status check) to drop the
needs.core-validation reference, its result-based summary lines, and the
failure condition that tested it.

Verification

Confirmed the org ruleset's four required status checks and their
producers before editing: CI Gate (ci.yml gate job), Security Gate Validation (security-analysis.yml), Check REUSE Compliance (reuse.yml),
Dependency & Standards Validation (pr-validation.yml validation-summary
job, preserved). None of these depend on core-validation.
actionlint .github/workflows/pr-validation.yml: no new findings; the
pre-existing shellcheck info/style notices in unrelated script blocks
actually decreased (16 to 13) since a script block was removed.
python -c "import yaml; yaml.safe_load(...)": parses cleanly.
pre-commit run --files .github/workflows/pr-validation.yml: all hooks
passed with SKIP=basedpyright (basedpyright fails on pre-existing type
errors in src/audio_processor/services/vad_processor.py, a file this PR
does not touch).

Generated with Claude Code

Summary by CodeRabbit

Chores
- Updated pull request validation reporting to rely on dead-code and link-check results.
- Removed core validation status and failure handling from the validation summary.

The core-validation job in pr-validation.yml re-invoked the shared python-ci.yml reusable at the same pinned SHA already called by ci.yml's ci job, roughly doubling PR CI cost (quality checks, unit tests, integration tests, security tests, coverage combine, LLM governance, and the Python matrix all ran twice per PR). Remove the core-validation job and its reusable call. Keep ci.yml's call as the single source of truth. Update validation-summary (which produces the required Dependency & Standards Validation status check) to drop the needs.core-validation reference, its result-based echo block, and the failure condition that tested it; leaving that reference in place after deleting the job would have caused the workflow to fail to parse. #CRITICAL validation-summary's required-context role was verified against the org ruleset (gh api repos/ByronWilliamsCPA/audio-processor/rules/branches/main) before this change: CI Gate is produced by ci.yml's gate job, Security Gate Validation by security-analysis.yml, and Check REUSE Compliance by reuse.yml, none of which reference core-validation. #VERIFY re-run the ruleset query after merge to confirm all four required contexts still report on the next PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-09-05T17:20:31Z

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

.github/workflows/pr-validation.yml

coderabbitai · 2026-09-05T17:20:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 8730f476-aa88-4e47-9b2e-5823c71427fd

📥 Commits

Reviewing files that changed from the base of the PR and between 35295ca and fbf4a23.

📒 Files selected for processing (1)

.github/workflows/pr-validation.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request removes the core-validation job from pull request validation. The validation summary now depends only on dead-code and link-check, and it no longer reports or fails on core-validation.

Changes

CI validation workflow

Layer / File(s)	Summary
Remove core-validation from validation workflow `.github/workflows/pr-validation.yml`	Removes the `core-validation` job and its Python CI configuration. Updates `validation-summary` dependencies, output, and failure handling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fbf4a

This removes duplicated Python CI runs while preserving the remaining validation status check and Python CI path. No current merge-blocking risk is identified.

Suggested labels: ci

Suggested reviewers: byronwilliamscpa

Poem

A rabbit trims the workflow line
Core checks hop out of the design
Dead code and links remain
The summary shows a simpler train
CI now follows a shorter chain

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: removing the duplicate Python CI invocation from pr-validation.yml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/remove-duplicate-python-ci-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sonarqubecloud · 2026-09-05T17:21:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

🟡 Changes recommended

The required validation-summary status check can still succeed even if its needed jobs fail, potentially masking upstream failures and allowing merges with incomplete validation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes the duplicate invocation of the org reusable python-ci.yml workflow from PR validation so core CI runs only once per PR (via .github/workflows/ci.yml), while keeping the required Dependency & Standards Validation status check produced by pr-validation.yml.

Changes:

Removed the core-validation job that re-called the shared python-ci.yml reusable workflow.
Updated validation-summary to drop needs.core-validation and remove the related summary/failure logic.

File summaries

File	Description
`.github/workflows/pr-validation.yml`	Removes the duplicate core CI reusable-workflow job and adjusts the required validation-summary job accordingly.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

          echo ""
          echo "✅ All validation checks passed!" >> $GITHUB_STEP_SUMMARY


Copilot AI lite review requested due to automatic review settings September 5, 2026 17:20

Copilot started reviewing on behalf of williaby September 5, 2026 17:20 View session

coderabbitai Bot added the ci label Sep 5, 2026

Copilot AI reviewed Sep 5, 2026

View reviewed changes

Comment thread .github/workflows/pr-validation.yml

Comment on lines 140 to 141

echo ""

echo "✅ All validation checks passed!" >> $GITHUB_STEP_SUMMARY

williaby added this pull request to the merge queue Sep 5, 2026

Merged via the queue into main with commit 0d425fd Sep 5, 2026
35 checks passed

williaby deleted the claude/remove-duplicate-python-ci-0 branch September 5, 2026 17:32

Navigation Menu

Uh oh!

Uh oh!

fix(ci): remove duplicate python-ci call from pr-validation.yml - #80

fix(ci): remove duplicate python-ci call from pr-validation.yml#80
williaby merged 1 commit into
mainfrom
claude/remove-duplicate-python-ci-0

williaby commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Sep 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		echo ""
		echo "✅ All validation checks passed!" >> $GITHUB_STEP_SUMMARY

Uh oh!

Uh oh!

Conversation

williaby commented Sep 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Before/after

Files changed

Verification

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Sep 5, 2026

Dependency Review

Scanned Files

Uh oh!

coderabbitai Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

sonarqubecloud Bot commented Sep 5, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

williaby commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading